Add function to start OSM signup in WebView #2477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note if we ever merge this, googles play store rules requires that we allow account deletion from the app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts the signup process in a webview and then captures the link from the confirmation e-mail to open it in the app. Pressing the "Start mapping" button then terminates the webview and leaves the user in Vespucci.
Would fix #1506 if merged, but that wont happen in a month of Sundays for obvious reasons.
If the world stood still and it is merged. it would need, besides a test, a bit more refinement, for example immediately authorizing the app via OAuth 2 and then returning to the app.