Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check disabled on layer remove, fix re-adding of controls overlay #321

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

ahmadayubi
Copy link
Member

2021-02-25.09-57-13.mp4

Closes #310 and closes #318

@ahmadayubi ahmadayubi changed the title Check disabled on layer remove, fix readding of controls overlay Check disabled on layer remove, fix re-adding of controls overlay Feb 25, 2021
@Malvoz
Copy link
Member

Malvoz commented Feb 25, 2021

This is great @ahmadayubi, though it seems to me that the Remove Layer button shouldn't be clickable if fieldset is disabled per https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#attr-fe-disabled (quoting the directly relevant parts):

A form control is disabled if any of the following conditions are met:

  1. The element is a descendant of a fieldset element whose disabled attribute is specified

A form control that is disabled must prevent any click events that are queued on the user interaction task source from being dispatched on the element.

But, if it's important that layers can be removed even if a layer item (<fieldset> as currently implemented) is disabled then perhaps that should be a consideration (for later) when refactoring the layer items' anatomy in #263.

@Malvoz
Copy link
Member

Malvoz commented Feb 25, 2021

Maybe I'm being a bit too strict about conforming to the HTML spec's behavior in this matter.

@prushforth prushforth merged commit 056b3b5 into Maps4HTML:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants