Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a remove layer button to controls #306

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

ahmadayubi
Copy link
Member

Closes #253

@prushforth prushforth requested a review from Malvoz February 22, 2021 17:57
src/mapml/layers/MapLayer.js Outdated Show resolved Hide resolved
@Malvoz
Copy link
Member

Malvoz commented Feb 22, 2021

There is a problem with the layer labels being cut off by the absolutely positioned button.

Setting a margin-right of 15 or 20px on the <label> could be a quick fix for now, although it may break if a user changes the font-size in their browser settings (since the icon is an HTML entity and not an img/svg). Otherwise flexbox may be a better solution. We should also try to ensure minimum dimensions of 44px (per #215). But I don't think it's worth spending too much time on these things until #263 is fixed since we'd probably end up rewriting that CSS anyways.

@ahmadayubi ahmadayubi marked this pull request as ready for review February 23, 2021 14:38
@ahmadayubi ahmadayubi requested a review from Malvoz February 23, 2021 14:45
@prushforth prushforth merged commit f42ee5e into Maps4HTML:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to remove layer from (DOM) map / layer control
3 participants