Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability: Pan, Zoom and Re-centre a Map #218

Merged
merged 4 commits into from
Sep 20, 2020

Conversation

NickFitz
Copy link
Contributor

This branch isn't ready for merging yet, but I'm adding this PR for it in case anybody has any comments while I'm working on these capabilities.

@NickFitz NickFitz marked this pull request as draft June 30, 2020 22:32
@NickFitz NickFitz force-pushed the capabilities-wip branch from 0e033f9 to a1d6ef3 Compare July 1, 2020 10:49
@NickFitz NickFitz marked this pull request as ready for review August 5, 2020 17:40
@NickFitz
Copy link
Contributor Author

NickFitz commented Aug 5, 2020

I'll remove this one's "Draft" status now as although it still has nothing in the "Related Specs" section, I'm having trouble thinking of any at the moment, and it's better if it's at least open for review :-)

@Malvoz
Copy link
Member

Malvoz commented Aug 5, 2020

In the "Related specs" section, I believe we should reference the CSS primitive proposal of "per-element panning and zooming": w3c/csswg-drafts#5275.

@NickFitz NickFitz changed the title Capabilities wip Capability: Pan, Zoom and Re-centre a Map Aug 5, 2020
@NickFitz
Copy link
Contributor Author

NickFitz commented Aug 5, 2020

In the "Related specs" section, I believe we should reference the CSS primitive proposal of "per-element panning and zooming": w3c/csswg-drafts#5275.

Ah, thanks - I'll review that and see about adding it.

@NickFitz
Copy link
Contributor Author

NickFitz commented Sep 1, 2020

I've added a link to the CSS-WG proposal as suggested by @Malvoz. (I'm not aware of, and couldn't find, any Respec way of adding a reference to a GitHub issue, so I've just put a normal link in there.)

@AmeliaBR AmeliaBR merged commit cf33ce2 into Maps4HTML:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants