Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] API keys: Update mapkitstatic referrer #208

Merged
merged 4 commits into from
May 12, 2020
Merged

[Examples] API keys: Update mapkitstatic referrer #208

merged 4 commits into from
May 12, 2020

Conversation

Malvoz
Copy link
Member

@Malvoz Malvoz commented Apr 1, 2020

No description provided.

@Malvoz Malvoz requested a review from NickFitz April 1, 2020 02:16
@AmeliaBR
Copy link
Member

AmeliaBR commented Apr 1, 2020

@NickFitz, I'll leave this up to you to approve & merge. I assume this was merely an oversight from #207, but this is a good time to make sure that there are no other errors.

@AmeliaBR
Copy link
Member

OK, I'm going to merge this & then we'll see if it fixes or breaks anything. (What with it being all about URLs, I'm not confident that a local test will prove anything!)

@AmeliaBR AmeliaBR merged commit f7e1d81 into Maps4HTML:master May 12, 2020
@Malvoz
Copy link
Member Author

Malvoz commented May 12, 2020

It shouldn't break anything, but it also seems this didn't fix the static maps example for MapKit. :(
Most likely an update is needed in the account itself.

@AmeliaBR
Copy link
Member

Ah, thanks for checking @Malvoz, I've opened a dedicated issue in #212 & I'll get in touch with Nick F to see if he has time to debug. Otherwise, I might need to set up some new API keys for the project & start from scratch.

Sigh… the worst part is knowing that authentication issues for accessing proprietary data are one thing we can't ever expect to 100% standardize away. Keeping map data up to date will always cost money & that means companies want to get paid.

@Malvoz
Copy link
Member Author

Malvoz commented May 12, 2020

Sigh… the worst part is knowing that authentication issues for accessing proprietary data are one thing we can't ever expect to 100% standardize away. Keeping map data up to date will always cost money & that means companies want to get paid.

Agreed, but I definitely think there are benefits in standardization, for one thing, Map API keys issue could perhaps utilize the Reporting API, making it easier for developers to retrieve notifications. Or how things should behave on the client when an API key has expired, for example Bings Maps API is displaying some information, although developer-oriented (fails due to localhost in this instance):

where other map tools would just cease to function silently:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants