-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More examples completed. #189
Conversation
Merge upstream changes.
Co-Authored-By: Amelia Bellamy-Royds <[email protected]>
Co-Authored-By: Amelia Bellamy-Royds <[email protected]>
Whoops. Somehow didn't get back to this when I did reviews last week. My only concern is adding framework-specific code to examples.css. When @nchan0154 had issues with the TomTom stylesheets code before, she added in local In the meantime, not sure what's the best strategy. I'd like to merge the rest of this. |
I'm also responsible for doing that, to make it easier to update styles as we had many duplicate inline styles and style blocks across multiple example pages. So adding a couple more of those now probably wont hurt, especially taking #193 (comment) into consideration. |
Yeah, I mean, the issue is less about which file to put the CSS in & more about making sure the selectors are sufficiently scoped so there aren't weird interactions & we can easily understand why each rule is there. |
Oh, I wasn't concerned with which file to put the CSS, but rather why adding inline styles now would be blocking this merge?
|
examples/reprojection.html
Outdated
@@ -0,0 +1,287 @@ | |||
<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to include this file in this PR?
If so, please link it from the correct part of index.html & change up the commented bits so that the headings are still visible & the unfinished examples use a single block comment.
(to at least keep them contained, until we figure out a better way to sandbox styles)
OK, I pushed my own "good enough" solution to the TomTom styles issue: I moved the icon rules into their own file, that we can link to everywhere we would link to the TomTom's full stylesheet that includes those rules. @NickFitz, when checking out the PR, I discovered a mostly commented-out example file. Were you intending to commit that yet? If so, can you tidy it up a bit? |
Add initial tags to capability conclusions
(to at least keep them contained, until we figure out a better way to sandbox styles)
(to at least keep them contained, until we figure out a better way to sandbox styles)
OK, merging everything. Sorry for the delay. Hoping to find some time/energy to catch up on more substantive reviews, soon. |
Still a few examples to go, but I'll get these over now so people can check them out (pun intended).