This repository has been archived by the owner on Feb 10, 2024. It is now read-only.
add(potions): portion rework #828
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MrLar
commented
Sep 22, 2023
•
MrLar
commented
- Mainly allows multiple kinds of potions to be equipped at once
- Adds a way to limit what buffs/potions can be stacked together (using PotionEffectType)
- Adds emotes to use item for potions
- Will add some potions and make some potions accessible through new/other means
- Ironically due to java reference types this only ever effected the milky potion and was also a thing pre-potion-rework
… distinction between potion/buff add(effects): rename waifu pill -> tea and make it conditionless (this is not a final decision) add(operations): add select menu ops fix(equipment): potions/buffs could be equipped lol fix(profile): buffs cmd failed if no buffs
Kodehawa
force-pushed
the
potion-rework
branch
from
3203330
to
7ec9460
Compare
add(item/buff): buff tea money gain (will stay money buff) add(item): streamline "is item usable" and "is item potion" checks add(usable): proper method name for handling usable items fix(buff): properly rename money key
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.