Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): templates & CSS cleanup #61

Merged
merged 15 commits into from
Sep 30, 2024
Merged

refactor(ui): templates & CSS cleanup #61

merged 15 commits into from
Sep 30, 2024

Conversation

GabDug
Copy link
Contributor

@GabDug GabDug commented May 14, 2024

  • Activate djhtml's djcss mode
  • Reformat some templates attributes
  • Fix some visual issues with newer Bulma releases
  • Remove some custom CSS: we are using Tailwind CSS, Daisy UI and custom Django components

@GabDug GabDug force-pushed the refactor/css-cleanup branch from 76df2bb to e24505b Compare July 11, 2024 14:50
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.80%. Comparing base (4d64afa) to head (9d8c6fc).

Files with missing lines Patch % Lines
...rc/firefighter/components/form_field/form_field.py 0.00% 1 Missing ⚠️
...s/templates/layouts/partials/incident_metrics.html 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   62.81%   62.80%   -0.01%     
==========================================
  Files         215      215              
  Lines        9573     9572       -1     
  Branches     1286     1286              
==========================================
- Hits         6013     6012       -1     
+ Misses       3352     3351       -1     
- Partials      208      209       +1     
Flag Coverage Δ
unittests 62.80% <81.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GabDug GabDug changed the title Refactor/css cleanup Refactor: templates & CSS cleanup Sep 30, 2024
@GabDug GabDug changed the title Refactor: templates & CSS cleanup refactor(ui): templates & CSS cleanup Sep 30, 2024
@GabDug GabDug self-assigned this Sep 30, 2024
@GabDug GabDug merged commit 86e516c into main Sep 30, 2024
4 checks passed
@GabDug GabDug deleted the refactor/css-cleanup branch September 30, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants