fixup: accidentally removed a setting

ManoManoTech · Jan 2, 2024 · bb5c182 · bb5c182
1 parent 7e2e9b5
commit bb5c182
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 8 deletions.
diff --git a/src/firefighter/firefighter/settings/components/slack.py b/src/firefighter/firefighter/settings/components/slack.py
@@ -28,6 +28,10 @@
     "SLACK_INCIDENT_HELP_GUIDE_URL", default=None
 )
 "URL to add in the Slack help message (/incident help). Useful to point to your own documentation."
+SLACK_SEVERITY_HELP_GUIDE_URL: str | None = config(
+    "SLACK_SEVERITY_HELP_GUIDE_URL", default=None
+)
+"URL to add in the form to choose the priority. Useful to point to your own documentation."
 SLACK_EMERGENCY_COMMUNICATION_GUIDE_URL: str | None = config(
     "SLACK_EMERGENCY_COMMUNICATION_GUIDE_URL", default=None
 )

diff --git a/src/firefighter/raid/views/open_normal.py b/src/firefighter/raid/views/open_normal.py
@@ -3,7 +3,6 @@
 import logging
 from typing import TYPE_CHECKING
 
-from django.conf import settings
 from slack_sdk.models.blocks.basic_components import MarkdownTextObject
 from slack_sdk.models.blocks.blocks import ContextBlock
 
@@ -23,8 +22,6 @@
 
 logger = logging.getLogger(__name__)
 
-SLACK_SEVERITY_HELP_GUIDE_URL: str = settings.SLACK_SEVERITY_HELP_GUIDE_URL
-
 slack_fields: SlackFormAttributesDict = {
     "title": {
         "input": {

diff --git a/src/firefighter/slack/views/modals/open.py b/src/firefighter/slack/views/modals/open.py
@@ -46,7 +46,7 @@
 app = SlackApp()
 logger = logging.getLogger(__name__)
 
-SLACK_SEVERITY_HELP_GUIDE_URL: str = settings.SLACK_SEVERITY_HELP_GUIDE_URL
+SLACK_SEVERITY_HELP_GUIDE_URL: str | None = settings.SLACK_SEVERITY_HELP_GUIDE_URL
 
 
 INCIDENT_TYPES: dict[ResponseType, dict[str, dict[str, Any]]] = {
@@ -411,7 +411,14 @@ def _build_response_type_blocks(open_incident_context: OpeningData) -> list[Bloc
                             MarkdownTextObject(
                                 text=f"> {priority.emoji} Selected priority: {priority}"
                                 + (
-                                    f"\n> Critical incidents are for *emergency* only, <{SLACK_SEVERITY_HELP_GUIDE_URL}|learn more>."
+                                    (
+                                        "\n> Critical incidents are for *emergency* only"
+                                        + (
+                                            f"<{SLACK_SEVERITY_HELP_GUIDE_URL}|learn more>"
+                                            if SLACK_SEVERITY_HELP_GUIDE_URL
+                                            else "" + "."
+                                        )
+                                    )
                                     if selected_response_type == "critical"
                                     else ""
                                 )

diff --git a/src/firefighter/slack/views/modals/opening/details/critical.py b/src/firefighter/slack/views/modals/opening/details/critical.py
@@ -50,7 +50,9 @@ class CreateIncidentFormSlack(CreateIncidentForm):
             "widget": {
                 "post_block": SectionBlock(
                     text=f"_<{settings.SLACK_SEVERITY_HELP_GUIDE_URL}|How to choose the priority?>_"
-                ),
+                )
+                if settings.SLACK_SEVERITY_HELP_GUIDE_URL
+                else None,
                 "label_from_instance": lambda obj: f"{obj.emoji}  {obj.name} - {obj.description}",
             },
         },

diff --git a/src/firefighter/slack/views/modals/update_status.py b/src/firefighter/slack/views/modals/update_status.py
@@ -43,8 +43,9 @@ class UpdateStatusFormSlack(UpdateStatusForm):
             "widget": {
                 "post_block": SectionBlock(
                     text=f"_<{settings.SLACK_SEVERITY_HELP_GUIDE_URL}|How to choose the priority?>_"
-                ),
-                # XXX Link to new Priority doc
+                )
+                if settings.SLACK_SEVERITY_HELP_GUIDE_URL
+                else None,
                 "label_from_instance": priority_label,
             },
         },