Request timeout option default to 15 instead of null

ManneW · May 18, 2015 · 7ed4193 · 7ed4193
1 parent 38d0cc6
commit 7ed4193
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
@@ -26,7 +26,7 @@ public function getConfigTreeBuilder()
                     ->info('If needed you can specify a proxy that is used when connecting to HipChat.')
                 ->end()
                 ->scalarNode('request_timeout')
-                    ->defaultNull()
+                    ->defaultValue(15)
                     ->info('In seconds. To change the default timeout of a HipChat API request.')
                 ->end()
             ->end();

diff --git a/README.md b/README.md
@@ -44,7 +44,7 @@ mannew_hipchat:
 	auth_token: YOUR_HIPCHAT_AUTH_TOKEN_HERE
 	verify_ssl: true    # optional
 	proxy_address: ~    # optional
-	request_timeout: ~  # in seconds, optional
+	request_timeout: 15 # in seconds, optional
 ```
 
 ## Usage

diff --git a/Tests/DependencyInjection/MannewHipchatExtensionTest.php b/Tests/DependencyInjection/MannewHipchatExtensionTest.php
@@ -103,7 +103,7 @@ public function testLoadConfigWithoutRequestTimeoutOption()
         $container = $this->getEmptyTestContainer();
         $this->loadConfigIntoContainer($config, $container);
 
-        $this->assertContainerParameterEquals($container, 'request_timeout', null);
+        $this->assertContainerParameterEquals($container, 'request_timeout', 15);
     }
 
     /**