Enhance input validation, CLI functionality, and testing for directLFQ #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwoer
approved these changes
Aug 13, 2024
directlfq/utils.py
Outdated
| @@ -310,6 +310,17 @@ def index_and_log_transform_input_df(data_df): | |||
| def remove_allnan_rows_input_df(data_df): | |||
| return data_df.dropna(axis = 0, how = 'all') | |||
|
|
|||
| def remove_potential_quant_id_duplicates(data_df): | |||
directlfq/utils.py
Outdated
| after_drop = len(data_df) | ||
| if before_drop != after_drop: | ||
| entries_removed = before_drop - after_drop | ||
| LOGGER.info(f"Duplicate quant_ids detected. {entries_removed} rows removed from input df.") |
Comment on lines
+316
to
+318
| after_drop = len(data_df) | ||
| if before_drop != after_drop: | ||
| entries_removed = before_drop - after_drop |
There was a problem hiding this comment.
(nit) could be simplified
if (entries_removed:= before_drop - after_drop):
|
thanks Magnus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds duplicate row handling, fixes a non-functional CLI option, expands quicktests with a CLI run, updates GitHub Actions workflows, and bumps the version to 0.2.20.