Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for accessory dynamic bones causing a faulty baseline to be collected. #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krypto5863
Copy link

@krypto5863 krypto5863 commented Dec 11, 2024

Fix for #58

I tried to keep things as simple as possible, when the baseline is first collected, we simply disable the component, which causes the bones to assume their resting position, collect the baseline, and set things back to how they were.

@krypto5863 krypto5863 changed the title Fix for https://github.com/ManlyMarco/ABMX/issues/58 Fix for #58 Dec 11, 2024
@krypto5863 krypto5863 changed the title Fix for #58 Fix for accessory dynamic bones causing a faulty baseline to be collected. Dec 11, 2024
Copy link
Owner

@ManlyMarco ManlyMarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new DB-related members should not be public unless there's already a plan to use them in another plugin.

Can there only ever be one DB affecting a bone? What if there's a DB inside another DB and you return the inner one because it's first in the list?

@krypto5863
Copy link
Author

krypto5863 commented Dec 12, 2024

I don't believe it should ever be the case that multiple DBs affect a bone or a string of bones, even if they're later on down the line. I think that'd be a bug tbh.

Nah pub prop is just an oversight, I'll make it internal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants