Merge pull request #163 from andersk/ignore-trace-panic

Allow dereferencing a rooted Gc during collection

gc/src/lib.rs

@@ -141,12 +141,12 @@ impl<T: ?Sized> Gc<T> {
     #[inline]
     fn inner_ptr(&self) -> *mut GcBox<T> {
         // If we are currently in the dropping phase of garbage collection,
-        // it would be undefined behavior to dereference this pointer.
+        // it would be undefined behavior to dereference an unrooted Gc.
         // By opting into `Trace` you agree to not dereference this pointer
         // within your drop method, meaning that it should be safe.
         //
         // This assert exists just in case.
-        assert!(finalizer_safe());
+        assert!(finalizer_safe() || self.rooted());
 
         unsafe { clear_root_bit(self.ptr_root.get()).as_ptr() }
     }

gc/tests/ignore_trace.rs

@@ -0,0 +1,12 @@
+use gc::{force_collect, Finalize, Gc, Trace};
+
+#[derive(Finalize, Trace)]
+struct S(#[unsafe_ignore_trace] Gc<()>);
+
+/// Using `#[unsafe_ignore_trace]` on a `Gc` may inhibit collection of
+/// cycles through that `Gc`, but it should not result in panics.
+#[test]
+fn ignore_trace_gc() {
+    Gc::new(S(Gc::new(())));
+    force_collect();
+}