feat: implement serde for all the containers #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to block this on figuring out the exact solution for #48 since that may change a bunch of the relevant internals here and I really don't want to complicate that situation more. |
|
I can revert those affected by #48 until this is fixed |
|
That's going to be most of the important ones, and plus the changes I do there may also affect other types like the BTreeMaps. I don't think it's worth landing this PR with those things removed. |
|
I actually prefer if you merge #62 before this PR as it allows me to test serialization/deserialization back-to-back via |
|
Waiting for #72 so that I can add the tests for all implementations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.