manager: Refactored tests. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
commented
Oct 1, 2024
•
bwplotka
commented
- Fixed conversion bug. OM Text CTs (and any timestamps) are in seconds, but CreatedTimestamp() parser expects millis.
- Make it more clear and consistent, especially around namings (names autogenerated, easier to figure out what case permutation we forgot to test)
- Don't manually handcraft OM text, use expfmt which we are using in client_golang anyway.
- Actually test timestamps.
Signed-off-by: bwplotka <[email protected]>
Maniktherana
merged commit 813322b
into
Maniktherana:implement-ct-in-append
19 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.