Skip to content

Commit

Permalink
Merge pull request prometheus#14004 from liam-howe-maersk/implement-c…
Browse files Browse the repository at this point in the history
…onfig-marshal

configuration: Implement IsZero for relabel.Regex to remove default regex
  • Loading branch information
beorn7 authored Jun 27, 2024
2 parents c5040c5 + 35d897c commit cb73061
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 0 deletions.
5 changes: 5 additions & 0 deletions model/relabel/relabel.go
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,11 @@ func (re Regexp) MarshalYAML() (interface{}, error) {
return nil, nil
}

// IsZero implements the yaml.IsZeroer interface.
func (re Regexp) IsZero() bool {
return re.Regexp == DefaultRelabelConfig.Regex.Regexp
}

// String returns the original string used to compile the regular expression.
func (re Regexp) String() string {
str := re.Regexp.String()
Expand Down
49 changes: 49 additions & 0 deletions model/relabel/relabel_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -851,3 +851,52 @@ func BenchmarkRelabel(b *testing.B) {
})
}
}

func TestConfig_UnmarshalThenMarshal(t *testing.T) {
tests := []struct {
name string
inputYaml string
}{
{
name: "Values provided",
inputYaml: `source_labels: [__meta_kubernetes_pod_annotation_prometheus_io_port]
separator: ;
regex: \\d+
target_label: __meta_kubernetes_pod_container_port_number
replacement: $1
action: replace
`,
},
{
name: "No regex provided",
inputYaml: `source_labels: [__meta_kubernetes_pod_annotation_prometheus_io_port]
separator: ;
target_label: __meta_kubernetes_pod_container_port_number
replacement: $1
action: keepequal
`,
},
{
name: "Default regex provided",
inputYaml: `source_labels: [__meta_kubernetes_pod_annotation_prometheus_io_port]
separator: ;
regex: (.*)
target_label: __meta_kubernetes_pod_container_port_number
replacement: $1
action: replace
`,
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
unmarshalled := Config{}
err := yaml.Unmarshal([]byte(test.inputYaml), &unmarshalled)
require.NoError(t, err)

marshalled, err := yaml.Marshal(&unmarshalled)
require.NoError(t, err)

require.Equal(t, test.inputYaml, string(marshalled))
})
}
}

0 comments on commit cb73061

Please sign in to comment.