TSDB: eliminate one yolostring

When the only use of a []byte->string conversion is as a map key, Go doesn't allocate. Signed-off-by: Bryan Boreham <[email protected]>
Maniktherana · Nov 26, 2024 · ca3119b · ca3119b
1 parent e98c19c
commit ca3119b
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/tsdb/index/index.go b/tsdb/index/index.go
@@ -610,10 +610,10 @@ func (w *Writer) writeLabelIndices() error {
 	values := []uint32{}
 	for d.Err() == nil && cnt > 0 {
 		cnt--
-		d.Uvarint()                           // Keycount.
-		name := d.UvarintBytes()              // Label name.
-		value := yoloString(d.UvarintBytes()) // Label value.
-		d.Uvarint64()                         // Offset.
+		d.Uvarint()               // Keycount.
+		name := d.UvarintBytes()  // Label name.
+		value := d.UvarintBytes() // Label value.
+		d.Uvarint64()             // Offset.
 		if len(name) == 0 {
 			continue // All index is ignored.
 		}
@@ -626,7 +626,7 @@ func (w *Writer) writeLabelIndices() error {
 			values = values[:0]
 		}
 		current = name
-		sid, ok := w.symbolCache[value]
+		sid, ok := w.symbolCache[string(value)]
 		if !ok {
 			return fmt.Errorf("symbol entry for %q does not exist", string(value))
 		}