[F] Add spam detection & public access mitigations #3720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scryptmouse
commented
Feb 22, 2024
scryptmouse
commented
- Implement refactor for section settings + test coverages
- Normalize request specs
- Add optional Akismet integration
- Add logic to prevent unconfirmed / untrusted users from commenting, creating new reading groups, and registering users
* Finishes up an in-progress branch to make settings easier to grok. * Normalizes settings into store models rather than arbitrary hash with multiple sources of truth across the application * Tightens up serializer to have parity with new section store models, ensures that the API definition actually declares which settings can be nil instead of relying on missing keys not tripping the validators. * Improve test coverage over updating settings from environment, pulling google drive data out of config files, and handling of unknown settings that may get set or exist from legacy use cases.
There was an obvious typo in the original logic that is being fixed in a separate commit to make it more clear what's happening. It should now read from the proper section setting.
* This gets rid of an annoying deprecation message that shows up every time the app / console boots.
* Behavior is inconsistent between swagger specs and normal request specs, causing order-of-operation problems when trying to use `let_it_be` / optimizations on certain records. This ensures all requests load the normalized contexts for further improvements and refinements when testing requests.
* Add akismet integration for detecting spam * Add new setting for disabling spam detection globally * Add ability to disable public reading groups * Require users to be trusted / established when commenting, creating a public annotation, or creating a public reading group
* Ensure application is eager loaded before running test suite * Filter out development / testing-only services to make coverage results more meaningful for reviewing gaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.