-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[F] Use query params in admin #3653
Conversation
c370351
to
dcf37b7
Compare
dcf37b7
to
d30e774
Compare
@dananjohnson It looks to me like this is basically done, and the only conflicts are snapshots that can be deleted. I'd need to update the new spam mitigation list views to match this and do a little testing, but it seems worth getting in? |
@1aurend that's great! Yeah I agree—it's worth merging and then utilizing in the new list views. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, @1aurend! Most things are working well, and the query params on the lists are a welcome change. I noticed a couple little issues that I'll describe below. I haven't looked at Manifold in awhile so I don't really know whether these relate to your PR or not. Feel free to suggest I open a separate Linear issue for any.
- I noticed one weird thing with project collections. Here's how to reproduce:
- Toggle drawer to create a new PC
- Fill out whatever fields and click "Save Project Collection"
- Notice that behind the drawer, the new PC is created and we are routed to it (
/backend/projects/project-collections/[slug]
). - Notice that the drawer doesn't close and a "You have unsaved changes" prompt appears.
- Also, when I try to visit a project's Exports page, I get an exception with the
project_exportations
fetch that crashes the page:
useFetch tried to fetch data more than 25 times. This suggests that an input to
useFetch needs to be memoized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@dananjohnson the project exports bug was related to this PR and was an easy fix. The PC drawer thing is an issue on Edge too, so I'm copying your notes into a separate Linear issue. I think it's an issue with how |
781604f
to
85c6c62
Compare
85c6c62
to
1aa0daa
Compare
This PR unifies how list pagination and filters are handled between the frontend and admin mode, using query params wherever a route's primary purpose is to display a single list. Pagination links are also changed to buttons rather than anchors where no valid href exists, e.g. on pages displaying multiple paginated lists.