Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Field Relative for Wrist #96

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

NinjaBuilderPro
Copy link
Contributor

No description provided.

@@ -71,6 +72,12 @@ public void setTarget(Rotation2d target) {
m_targetDegrees = targetDegrees;
}

public void setTarget(double target) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the other setTarget call this one?

@jnallard
Copy link
Contributor

jnallard commented Mar 3, 2023

@NinjaBuilderPro and others, thanks for doing this.
But since we didn't have time to test this and the ArmRelative was working, I decided to push adding this until after GSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants