DRb has been extracted from stdlib to a gem #23232
Conversation
Gemfile
Outdated
| @@ -38,6 +38,7 @@ gem "connection_pool", :require => false # | |||
| gem "dalli", "~>3.2.3", :require => false | |||
| gem "default_value_for", "~>4.0" | |||
| gem "docker-api", "~>1.33.6", :require => false | |||
| gem "drb", "~>2.1.1", :require => false | |||
There was a problem hiding this comment.
NOTE ruby 3.1.0 has drb version 2.1.1 so that's what I used here, the latest (and what is in 3.3) is 2.2.1.
Though looking at the changes (https://my.diffend.io/gems/drb/2.1.1/2.2.0 and https://my.diffend.io/gems/drb/2.2.0/2.2.1) it is probably safe to use 2.2.1 on any of our current ruby versions
There was a problem hiding this comment.
I'm leaning towards 2.2.1.
We will be changing this in the short term anyway
|
@miq-bot cross-repo-tests /all |
From Pull Request: ManageIQ/manageiq#23232
agrare
force-pushed
the
add_drb_to_gemfile
branch
from
751e129
to
7dd425d
Compare
Gemfile
Outdated
| @@ -38,6 +38,7 @@ gem "connection_pool", :require => false # | |||
| gem "dalli", "~>3.2.3", :require => false | |||
| gem "default_value_for", "~>4.0" | |||
| gem "docker-api", "~>1.33.6", :require => false | |||
| gem "drb", "~>2.2.1", :require => false | |||
There was a problem hiding this comment.
I'm wondering if we should be more open - maybe ">=2.2.1" or "~>2.2" ?
There was a problem hiding this comment.
Sure ~>2.2 would work, don't want to accidentally pull in a breaking change
Add DRb to the Gemfile as a gem as it has been extracted from stdlib to a standalone gem. ``` lib/miq_automation_engine/miq_ae_exception.rb:1: warning: lib/ruby/3.3.0/drb.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0. You can add drb to your Gemfile or gemspec to silence this warning. ```
agrare
force-pushed
the
add_drb_to_gemfile
branch
from
7dd425d
to
5103e69
Compare
|
Okay changed to |
|
Checked commit agrare@5103e69 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Add DRb to the Gemfile as a gem as it has been extracted from stdlib to a standalone gem.