Replace Container ENV var EMS_IDS->_ID #23195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workers having a comma separated list of EMS IDs has been replaced with moving child-manager refresh logic into the parent-manager refresher.
agrare
force-pushed
the
deployment_per_worker_ems_ids
branch
from
4703bf3
to
41d5fad
Compare
|
Checked commit agrare@41d5fad with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
jrafanie
approved these changes
Sep 19, 2024
|
Ha yeah I keep finding more, I think this is the last of them though (famous last words) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workers having a comma separated list of EMS IDs has been replaced with moving child-manager refresh logic into the parent-manager refresher.
I noticed this while investigating the OpentofuWorker, it is also odd that deployment-per-worker also assumes that it is an EMS worker which isn't necessarily the case.
I think a better approach would be to move the environment variable logic out of how the workers are managed by kubernetes, and unify it with how systemd handles environment variables per-worker with the
unit_environment_variablesmethod (which already handles EMS_ID).Co-depends: