Prefer UBI and go download over library/golang #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdunne
commented
Oct 1, 2024
bdunne
commented
- speed up build since there is less to download
- reduce external dependencies
- build and run on the same base image
Fryguy
reviewed
Oct 1, 2024
bdunne
commented
Oct 2, 2024
| FROM docker.io/library/golang:1.23 as builder | ||
| FROM registry.access.redhat.com/ubi9/ubi-minimal as builder | ||
|
|
||
| COPY go.mod /go.mod |
There was a problem hiding this comment.
This is used to detect the desired Go major.minor version, but could be changed to an ENV var if we want to extract this to a script for reuse.
kschanrtp
reviewed
Oct 2, 2024
kschanrtp
reviewed
Oct 2, 2024
Fryguy
reviewed
Oct 2, 2024
Fryguy
reviewed
Oct 2, 2024
|
I am curious what's in the golang image that causes it to be so much larger |
Fryguy
reviewed
Oct 2, 2024
Fryguy
approved these changes
Oct 2, 2024
- speed up build since there is less to download - reduce external dependencies - build and run on the same base image REPOSITORY TAG IMAGE ID CREATED SIZE my test 422e3c099772 10 seconds ago 366 MB docker.io/library/golang 1.23 361d8b5c9aa5 3 weeks ago 862 MB CP4AIOPS-7146
Fryguy
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.