Merge pull request #89 from nasark/close_rdkafka_admin_client_connection

Close Kafka admin client connection
ManageIQ · May 3, 2024 · f41e17b · f41e17b
2 parents 0fd700a + d784d26
commit f41e17b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/manageiq/messaging/kafka/client.rb b/lib/manageiq/messaging/kafka/client.rb
@@ -56,6 +56,9 @@ def ack(ack_ref)
         end
 
         def close
+          @admin&.close
+          @admin = nil
+
           @producer&.close
           @producer = nil
 
@@ -65,7 +68,7 @@ def close
 
         # list all topics
         def topics
-          kafka_client.admin.metadata.topics.map { |topic| topic[:topic_name] }
+          admin.metadata.topics.map { |topic| topic[:topic_name] }
         end
 
         private

diff --git a/lib/manageiq/messaging/kafka/common.rb b/lib/manageiq/messaging/kafka/common.rb
@@ -8,6 +8,10 @@ module Common
 
         private
 
+        def admin
+          @admin ||= kafka_client.admin
+        end
+
         def producer
           @producer ||= kafka_client.producer
         end