This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[WIPTEST][NOTEST] Add MA test coverage #10262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ganeshhubale
commented
Jul 21, 2020
ganeshhubale
commented
- Removed test case - test_enable_migration_analytics (This feature is by default enabled)
valaparthvi
suggested changes
Jul 21, 2020
Comment on lines
249
to
255
| testSteps: | ||
| 1. Download payload file | ||
| expectedResults: | ||
| 1. Check if below attributes available in file: | ||
| "cpu_affinity": null, | ||
| "memory_hot_add_enabled": null, | ||
| "cpu_hot_add_enabled": null, | ||
| "cpu_hot_remove_enabled": null, |
There was a problem hiding this comment.
Suggested change
| testSteps: | |
| 1. Download payload file | |
| expectedResults: | |
| 1. Check if below attributes available in file: | |
| "cpu_affinity": null, | |
| "memory_hot_add_enabled": null, | |
| "cpu_hot_add_enabled": null, | |
| "cpu_hot_remove_enabled": null, | |
| testSteps: | |
| 1. Download the payload file | |
| 2. Check if below attributes are available in the file: | |
| "cpu_affinity": null, | |
| "memory_hot_add_enabled": null, | |
| "cpu_hot_add_enabled": null, | |
| "cpu_hot_remove_enabled": null, | |
| expectedResults: | |
| 1. File is downloaded successfully. | |
| 2. All the attributes are available in the file. |
| startsin: 5.11 | ||
| casecomponent: MigrationAnalytics | ||
| setup: | ||
| 1. Add a file to SSA profile that includes weird characters. |
There was a problem hiding this comment.
Can you also put a few examples of weird characters?
| assignee: ghubale | ||
| initialEstimate: 1/4h | ||
| startsin: 5.11 | ||
| casecomponent: MigrationAnalytics |
Comment on lines
+253
to
+255
| "cpu_affinity": null, | ||
| "memory_hot_add_enabled": null, | ||
| "cpu_hot_add_enabled": null, | ||
| "cpu_hot_remove_enabled": null, |
There was a problem hiding this comment.
Thoughts on parametrizing these attributes?
There was a problem hiding this comment.
These are in payoad json file, No need to parameterize
| assignee: ghubale | ||
| initialEstimate: 1/4h | ||
| startsin: 5.11 | ||
| casecomponent: MigrationAnalytics |
Signed-off-by: Ganesh Hubale <[email protected]>
ganeshhubale
force-pushed
the
new-ma-test
branch
from
762f72b
to
a212141
Compare
john-dupuy
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.