Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking release 0.22 #4477

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

Breaking release 0.22 #4477

wants to merge 17 commits into from

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Oct 14, 2024

Description

PR for the next breaking release

Merge TODO:

To fix:

  • partially reversed 2x2 surface fails surface(210..180, 80..110, rand(2, 2)) in WGLMakie (picking test)

@ffreyer ffreyer added the breaking a PR with breaking changes label Oct 14, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Oct 14, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 6.05s (5.70, 6.39) 0.21+- 180.35ms (161.67, 206.00) 14.44+- 669.08ms (629.64, 726.80) 26.89+- 7.28ms (6.85, 8.47) 0.49+- 26.33ms (25.44, 26.97) 0.48+-
master 6.62s (6.19, 7.07) 0.25+- 179.34ms (159.40, 206.46) 14.48+- 501.78ms (466.16, 549.95) 24.23+- 7.31ms (6.75, 8.33) 0.51+- 26.34ms (25.46, 27.11) 0.47+-
evaluation 1.10x faster✅, -0.58s (-2.52d, 0.00p, 0.23std) 0.99x invariant, 1.01ms (0.07d, 0.83p, 14.46std) 0.75x slower❌, 167.3ms (6.54d, 0.00p, 25.56std) 1.00x invariant, -0.03ms (-0.06d, 0.86p, 0.50std) 1.00x invariant, -0.02ms (-0.03d, 0.92p, 0.48std)
CairoMakie 5.64s (5.59, 5.70) 0.03+- 166.83ms (162.98, 172.79) 2.22+- 195.68ms (192.18, 199.11) 2.02+- 6.72ms (6.67, 6.77) 0.04+- 1.03ms (1.02, 1.04) 0.01+-
master 5.92s (5.88, 6.02) 0.04+- 161.98ms (157.95, 163.99) 1.48+- 198.95ms (194.18, 205.35) 2.74+- 6.80ms (6.70, 6.88) 0.04+- 1.07ms (1.06, 1.09) 0.01+-
evaluation 1.05x faster✅, -0.28s (-8.85d, 0.00p, 0.03std) 0.97x slower X, 4.85ms (2.58d, 0.00p, 1.85std) 1.02x faster ✓, -3.27ms (-1.36d, 0.00p, 2.38std) 1.01x faster ✓, -0.08ms (-2.03d, 0.00p, 0.04std) 1.04x faster ✓, -0.04ms (-5.36d, 0.00p, 0.01std)
WGLMakie 5.98s (5.84, 6.13) 0.09+- 171.38ms (162.47, 183.15) 6.25+- 5.90s (5.76, 6.11) 0.11+- 10.57ms (10.27, 11.35) 0.24+- 147.53ms (144.03, 157.61) 2.74+-
master 6.60s (6.44, 6.85) 0.12+- 167.95ms (159.08, 184.70) 7.20+- 5.96s (5.77, 6.28) 0.12+- 10.77ms (10.26, 12.07) 0.47+- 146.85ms (143.96, 149.68) 1.50+-
evaluation 1.10x faster✅, -0.61s (-5.92d, 0.00p, 0.10std) 0.98x invariant, 3.43ms (0.51d, 0.12p, 6.73std) 1.01x invariant, -0.06s (-0.54d, 0.09p, 0.11std) 1.02x invariant, -0.19ms (-0.52d, 0.11p, 0.35std) 1.00x invariant, 0.69ms (0.31d, 0.33p, 2.12std)

ffreyer and others added 11 commits October 16, 2024 13:36
* get Makie to compile

* get GLMakie to compile

* fix  nromal rename, meshscatter

* fix pointtype in mesh conversion

* avoid matrix in vector rotation

* fix more tests

* update GeometryBasics functions/interface

* fix voronoiplot clipping

* update CairoMakie

* update RPRMakie

* prepare WGLMakie

* Update CI to use the GeometryBasics refactor branch (#4326)

* Update ci.yml

* Update Docs.yml

* Update reference_tests.yml

* add MeshIO branch

---------

Co-authored-by: ffreyer <[email protected]>

* update _faces

* normals -> normal

* add ShaderAbstractions to ci

* update docs, normals deprecation

* fix branch names

* fix catmesh getting normals regenerated

* update for ShaderAbstractions

* handle voxel clipping in CairoMakie like in GLMakie

* fix another two "normals"

* add dev branches for RPRMakie CI

* fix missing kwarg name in conversion

* update for FaceViews

* add example for per-face colors and normals

* improve typing

* fix Sampler, allow mipmap via Sampler

* try to fix benchmarks

* add to correct env

* remove from master project

* fix docs

* fix Rect decomposition

* fix poly converts

* fix typo

* improve precompilation by avoiding constprop and more direct icon loading via PNGFiles

* fix CairoMakie precompile

* fix old syntax

* fix ambient light

* add temp dependencies to relocatbility test

* bump RPR to required version

* update changelog

* fix test

* fix other branch in ray cast test

* fix relocatability ci

* fix rpr and relocatability

---------

Co-authored-by: Anshul Singhvi <[email protected]>
Co-authored-by: SimonDanisch <[email protected]>
@ffreyer ffreyer closed this Oct 21, 2024
@ffreyer ffreyer reopened this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking a PR with breaking changes
Projects
Status: Work in progress
Development

Successfully merging this pull request may close these issues.

2 participants