Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With Julia 1.11 the "scatter inputs" refimg now fails because
rand(MersenneTwister(1337))
which is used inPlotUtils.adapted_grid()
produces different results.With PlotUtils 1.4.2 we switched to a StableRNG for that piece of code which should avoid the version differences but still requires a refimg test update here.
TODO:
Previous fix
This pr aims to fix the Problem by allowing StableRNG to be passed.
Some Notes:
used_attributes
may not be a very stable solution, and it requires explicit passing in refimg testsseed!
to reset the rng would solve that issue, but we can't useRandom.default_rng()
in that case (we mustn't reset the global rng)Type of change