Allow GLMakie to display surfaces transformed by a 3d transform func #4243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
|
asinghvi17
changed the title
asinghvi17
commented
Sep 3, 2024
|
Bump @SimonDanisch, could this be reviewed? Thanks :D |
ffreyer
reviewed
Oct 18, 2024
Comment on lines
827
to
+828
| matrix = if x isa AbstractMatrix && y isa AbstractMatrix | ||
| Makie.f32_convert(f32c, apply_transform.((t,), Point.(x, y), space), space) | ||
| [Makie.f32_convert(f32c, apply_transform(t, Point3(x, y, z[ix, iy]), space), space) for (ix, x) in pairs(x), (iy, y) in pairs(y)] |
There was a problem hiding this comment.
Isn't this calling z[CartesianIndex(...), CartesianIndex(...)]?
There was a problem hiding this comment.
Should probably also extend the refimg test to test
| vec-vec | vec-mat |
|---|---|
| mat-vec | mat-mat |
inputs
There was a problem hiding this comment.
Good point, and will test that.
There was a problem hiding this comment.
This could probably also be a loop operating on a pre-allocated array - that would be much clearer I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2890
Modifies GLMakie to be able to use 2D to 3D transformations in
surface.Type of change
Checklist