Protect against logical comparison errors in wifi_connect.c #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If additional flags are set in the wifi events, a direct comparison of "result == CONNECTED" will fail even if the bits are set. Since these flags were cleared, the wifi will be connected but never return the correct status from "wifi_connect_sta".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any additional bits are being used in
wifi_connect(eg. by setting both aCONNECTEDandIP_ASSIGNEDflag), a direct comparison ofresult == CONNECTEDwill fail even if theCONNECTEDbit is set, due to the presence of other bits.Since the checked flags are cleared via
xClearOnExit = pdTRUE, the flag notifying an IP assignment will be lost, and not set again in any reasonable amount of time. This is a simple change to evaluate the bitwise&result of the return to evaluate if the correct flag has been set.