Move to cartesian index for frequency filtering #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atm features duplicate SNR computation, could be further optimized later
|
I did a quick review and this change looks good! Just some tests are broken and need to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a linear index for frequency filtering/handling can cause a variety of issues in upstream code. For example it is cumbersome to see which component belongs to which channel or there can be ambiguity issues if filtering is applied to files with different numbers of frequencies.
This moves away from a linear index and instead uses a vector cartesian index. Upstream this is already supported in the upcomig MPIReco update