PM2 Fix (again): add pm2_env.unique_id checking and cleaning

[bugsounet]

#3605 : new purpose code with pm2_env.unique_id checking

[FrankBlackMG]

@bugsounet, I just tested your code changes. All looks good except for this one line.

if (!this.PM2) {

Since this.PM2 is the pm2 index number and it's zero based, you can get the wrong message that PM2 is not in use if MagicMirror happens to be listed first in your managed PM2 process list. Which mine is (and the only).

[2024-11-07 08:55:45.037] [DEBUG] updatenotification: [PM2] found pm2 process id: 0 -- name: mm -- unique_id: b214dbca-7f38-4a3d-9adf-0da9328502a7 
[2024-11-07 08:55:45.037] [INFO]  updatenotification: [PM2] You are using pm2 with id: 0 (mm) 
[2024-11-07 08:55:45.040] [INFO]  updatenotification: [PM2] You are not using pm2 

[sdetweil]

i didn't notice that, i set mine to -1 before looking

[khassel]

I'm not happy with moving this to top level.

Problem: With this statement pm2 starts already process(es) in the background so people not using pm2 have this unneeded and unwanted processes running, e.g. in a docker container.

So this should only called after Checking PM2 using as before.

[bugsounet]

@khassel : ok, i will reverse it.
@FrankBlackMG : you have right ;)

rejas merges it at lightning speed! (it's my fault I should have drafted it)