Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compliments): add configuration for refreshing remote file on interval #3608

Conversation

xsorifc28
Copy link

Hello and thank you for wanting to contribute to the MagicMirror² project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.
  2. Include these infos in the description:
  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run npm run lint:prettier before submitting so that
    style issues are fixed.
  2. Don't forget to add an entry about your changes to
    the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

@xsorifc28 xsorifc28 changed the title Feat/compliments remote file interval feat(compliments): add configuration for refreshing remote file on interval Oct 29, 2024
@rejas
Copy link
Collaborator

rejas commented Oct 31, 2024

Thanks for your PR.
Two things though:

  • could you update the PR description and get rid of the default text?
  • can you look into why the test are failing for the compliments now?

@sdetweil
Copy link
Collaborator

more than likely a syntax error

node -c compliments.js

will check language syntax

@sdetweil
Copy link
Collaborator

sdetweil commented Nov 9, 2024

I just pushed PR 3630 which does all and with testcases, using your code plus more

@xsorifc28
Copy link
Author

I just pushed PR 3630 which does all and with testcases, using your code plus more

Thank you much, apologies I have not been able to invest the time to ramp up on the project.

@xsorifc28
Copy link
Author

Closing in favor of #3630

@xsorifc28 xsorifc28 closed this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants