-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wayland and windows start options #3594
Add wayland and windows start options #3594
Conversation
I dropped the attempt to add an windows installation option for this PR. |
@KristjanESPERANTO if you used my shell js app it could be on install-mm |
I think it's good to handle this in different PRs. This one handles the start options and a new one could handle the installation. |
btw tested this in VirtualBox "install-mm:windows": "cmd /c npm install --ignore-scripts --no-audit --no-fund --no-update-notifier --only=prod --omit=dev && echo 'Installing vendor files ...' && cd vendor && npm install --loglevel=error --no-audit --no-fund --no-update-notifier && echo 'Installing fonts ...' && cd fonts && npm install --loglevel=error --no-audit --no-fund --no-update-notifier",` and beside a small error (should be |
i think this could have been done together my postinstall using my launcher "postinstall": "node js/es.js \"npm run install-vendor && npm run install-fonts && echo MagicMirror² installation finished successfully!\n\":npm run install-vendor & npm run install-fonts & echo MagicMirror² installation finished successfully!", then we don't need multiple divergent commands.. (to document and support) |
then we just use run mm-install |
we can do the same on start too.. js/es.js linux_command : windows_command less confusing for our users.. |
According to the changes in PR MagicMirrorOrg/MagicMirror#3594.
We would need something like this:
Yes, but different start options should not overwhelm a tinkerer. Also, when someone uses the additional commands, they should always be reminded that they are doing something that is not the default. This might help them to solve problems themselves and need less support. Perhaps I will argue in a different direction in the future 😅. But I often have the thought that it might not be a good idea to make it too easy for our users (who are tinkerers). If we automate everything, they understand the system less and need more support. That's why I liked the decision that only the manual installation is the official one. |
According to the changes in PR MagicMirrorOrg/MagicMirror#3594.
This PR adds start options for Wayland and Windows.
This would solve issue #3582.
To Do if this PR is merged: