Init basic version #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiidonii
reviewed
Nov 7, 2024
| - name: Install dependencies | ||
| run: composer install --ignore-platform-req=ext-opentelemetry | ||
|
|
||
| - name: Run PHPUnit tests |
There was a problem hiding this comment.
не вистачає ще степу зі збором coverage і відправкою репорта в codecov
https://github.com/MacPaw/behat-messenger-context/blob/develop/.github/workflows/ci.yaml#L72
serhiidonii
reviewed
Nov 7, 2024
| ## Setup bundle | ||
|
|
||
| ## Kernel event listeners | ||
| Example of kernel event listener implementation can be found in `Macpaw\SymfonyOtelBundle\Span\ExecutionTimeSpanTracer` class. |
There was a problem hiding this comment.
з опису не зрозуміло як це використовувати, було б непогано накидати екземплів
serhiidonii
reviewed
Nov 7, 2024
| $listeners = $container->getParameter('otel_bundle.span_tracers'); | ||
|
|
||
| foreach ($listeners as $listener) { | ||
| $definition = $container->register($listener['class'], $listener['class']); |
There was a problem hiding this comment.
$definition = new Definition($listener['class']);or
$definition = $container->hasDefinition($listener['class']) ? $container->getDefinition($listener['class']) : new Definition($listener['class']);
serhiidonii
reviewed
Nov 7, 2024
composer.json
Outdated
| "php": "^8.2", | ||
| "ext-opentelemetry": "*", | ||
| "symfony/dependency-injection": "^6.4|^7.0", | ||
| "symfony/config": "^7.0", |
serhiidonii
reviewed
Nov 7, 2024
composer.json
Outdated
| "ext-opentelemetry": "*", | ||
| "symfony/dependency-injection": "^6.4|^7.0", | ||
| "symfony/config": "^7.0", | ||
| "symfony/yaml": "^7.0", |
serhiidonii
reviewed
Nov 7, 2024
composer.json
Outdated
| "symfony/config": "^7.0", | ||
| "symfony/yaml": "^7.0", | ||
| "open-telemetry/symfony-sdk-bundle": "^0.0.25", | ||
| "symfony/http-client": "^7.0", |
serhiidonii
reviewed
Nov 7, 2024
composer.json
Outdated
| "nyholm/psr7": "^1.8", | ||
| "guzzlehttp/promises": "^2.0", | ||
| "php-http/httplug": "^2.4", | ||
| "symfony/http-kernel": "^7.0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the initial version of the decoration for the official Symfony OpenTelemetry Client Bundle. The bundle simplifies the integration and configuration of telemetry collection via a list of Kernel listeners.