Skip to content

Commit

Permalink
Merge pull request #158 from MacPaw/fix/warning-form-row
Browse files Browse the repository at this point in the history 
fix: remove unused props to fix warning for some pages
  • Loading branch information
@hraboviyvadim
hraboviyvadim authored Oct 13, 2023
2 parents 575e991 + 5dd3984 commit 4f7ccbb
Show file tree
Hide file tree
Showing 7 changed files with 56 additions and 46 deletions.
10 changes: 10 additions & 0 deletions .changeset/angry-singers-tickle.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@macpaw/macpaw-ui": minor
---

- bump Node.js version from 16 to 20
- update ui-kit iner UI
- fix warnings about usage of deprecated methods like defaultProps
- fix warining in FormRow component
- merge dependabot PRs
- bump Next.js from 12 to 13
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import '@macpaw/macpaw-ui/lib/ui.css';

## Requirements

- Node 16+
- Node 20+
- npm 7+ (lock file v2)

## Library Release Process
Expand Down
28 changes: 14 additions & 14 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"lodash.debounce": "^4.0.8",
"lodash.isempty": "^4.4.0",
"lodash.unionwith": "^4.6.0",
"react-day-picker": "^8.3.7",
"react-day-picker": "^8.8.2",
"react-toastify": "^9.1.3"
},
"peerDependencies": {
Expand Down Expand Up @@ -56,7 +56,7 @@
"@types/lodash.isempty": "^4.4.7",
"@types/lodash.unionwith": "^4.6.7",
"@types/node": "^16.4.3",
"@types/react": "^18.0.10",
"@types/react": "^18.2.28",
"@types/react-dom": "^18.2.8",
"@types/react-transition-group": "^4.4.0",
"clsx": "^1.1.1",
Expand Down
20 changes: 10 additions & 10 deletions pages/docs/checkbox.mdx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@ import { Checkbox, FormRow } from '../../src/ui';

# Checkbox

<FormRow variety><Checkbox>Default</Checkbox></FormRow>
<FormRow variety><Checkbox style={{ fontSize: 16 }}>Default</Checkbox></FormRow>
<FormRow variety><Checkbox defaultChecked>Checked</Checkbox></FormRow>
<FormRow variety><Checkbox disabled>Disabled</Checkbox></FormRow>
<FormRow variety><Checkbox error>Error</Checkbox></FormRow>
<FormRow><Checkbox>Default</Checkbox></FormRow>
<FormRow><Checkbox style={{ fontSize: 16 }}>Default</Checkbox></FormRow>
<FormRow><Checkbox defaultChecked>Checked</Checkbox></FormRow>
<FormRow><Checkbox disabled>Disabled</Checkbox></FormRow>
<FormRow><Checkbox error>Error</Checkbox></FormRow>

```
<FormRow variety><Checkbox>Default</Checkbox></FormRow>
<FormRow variety><Checkbox style={{ fontSize: 16 }}>Default</Checkbox></FormRow>
<FormRow variety><Checkbox defaultChecked>Checked</Checkbox></FormRow>
<FormRow variety><Checkbox disabled>Disabled</Checkbox></FormRow>
<FormRow variety><Checkbox error>Error</Checkbox></FormRow>
<FormRow><Checkbox>Default</Checkbox></FormRow>
<FormRow><Checkbox style={{ fontSize: 16 }}>Default</Checkbox></FormRow>
<FormRow><Checkbox defaultChecked>Checked</Checkbox></FormRow>
<FormRow><Checkbox disabled>Disabled</Checkbox></FormRow>
<FormRow><Checkbox error>Error</Checkbox></FormRow>
```
18 changes: 9 additions & 9 deletions pages/docs/radio.mdx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ import { Radio, FormRow } from '../../src/ui';

# Radio

<FormRow variety><Radio name="cat">Default</Radio></FormRow>
<FormRow variety><Radio name="cat" defaultChecked>Checked</Radio></FormRow>
<FormRow variety><Radio name="cat" disabled>Disabled</Radio></FormRow>
<FormRow variety><Radio name="cat" error>Error</Radio></FormRow>
<FormRow><Radio name="cat">Default</Radio></FormRow>
<FormRow><Radio name="cat" defaultChecked>Checked</Radio></FormRow>
<FormRow><Radio name="cat" disabled>Disabled</Radio></FormRow>
<FormRow><Radio name="cat" error>Error</Radio></FormRow>

```
<FormRow variety><Radio name="cat">Default</Radio></FormRow>
<FormRow variety><Radio name="cat" defaultChecked>Checked</Radio></FormRow>
<FormRow variety><Radio name="cat" disabled>Disabled</Radio></FormRow>
<FormRow variety><Radio name="cat" error>Error</Radio></FormRow>
```
<FormRow><Radio name="cat">Default</Radio></FormRow>
<FormRow><Radio name="cat" defaultChecked>Checked</Radio></FormRow>
<FormRow><Radio name="cat" disabled>Disabled</Radio></FormRow>
<FormRow><Radio name="cat" error>Error</Radio></FormRow>
```
20 changes: 10 additions & 10 deletions pages/docs/switch.mdx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,53 +2,53 @@ import { Switch, FormRow } from '../../src/ui';

# Switch

<FormRow variety>
<FormRow>
<h3>Default</h3>
<Switch />
</FormRow>

<FormRow variety>
<FormRow>
<h3>Disabled</h3>
<Switch disabled />
</FormRow>

<FormRow variety>
<FormRow>
<h3>Error</h3>
<Switch error>Some label</Switch>
</FormRow>

<FormRow variety>
<FormRow>
<h3>With handler</h3>
<Switch onChange={() => alert('Value is change')} />
</FormRow>

<FormRow variety>
<FormRow>
<h3>With Label</h3>
<Switch>change settings</Switch>
</FormRow>

```
<FormRow variety>
<FormRow>
<h3>Default</h3>
<Switch />
</FormRow>
<FormRow variety>
<FormRow>
<h3>Disabled</h3>
<Switch disabled />
</FormRow>
<FormRow variety>
<FormRow>
<h3>Error</h3>
<Switch error />
</FormRow>
<FormRow variety>
<FormRow>
<h3>With handler</h3>
<Switch onChange={() => alert('Value is change')} />
</FormRow>
<FormRow variety>
<FormRow>
<h3>With Label</h3>
<Switch>change settings</Switch>
</FormRow>
Expand Down

0 comments on commit 4f7ccbb

Please sign in to comment.