feat: make user Alias unique on create - prevent accidentally double … #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…creation of a player
|
I think it would be good to check this in the frontend as well, so ab error can be displayed immediately without going to the server first. |
But additionally check on server side 👍 |
|
@MaSch0212 I've added the client side check - and also the ability to open the previously named "user created" view (where you are able to copy the welcome message and the password) on the "edit User" page. With this, it is possible to get the welcome message in case a user has been created at an earlier time. Notice the new button next to the password field |
|
Will have a look tomorrow. |
MaSch0212
requested changes
Jul 18, 2024
src/client/src/app/components/users/user-dialog/user-dialog.component.ts
Outdated
Show resolved
Hide resolved
src/client/src/app/components/users/user-dialog/user-dialog.component.ts
Outdated
Show resolved
Hide resolved
src/client/src/app/components/users/user-welcome-dialog/user-welcome-dialog.component.html
Outdated
Show resolved
Hide resolved
…elcome-dialog.component.html Co-authored-by: Marc Schmidt <[email protected]>
MaSch0212
approved these changes
Jul 18, 2024
src/client/src/app/components/users/user-welcome-dialog/user-welcome-dialog.component.ts
Outdated
Show resolved
Hide resolved
MaSch0212
approved these changes
Jul 18, 2024
MaSch0212
deleted the
142-warn-if-user-would-be-created-which-alias-already-exists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…creation of a player