style: add eslint rule for ng decorator array sorting (#135)

MaSch0212 · Jul 7, 2024 · be73baf · be73baf
1 parent 24be04b
commit be73baf
Show file tree

Hide file tree

Showing 15 changed files with 48 additions and 25 deletions.
diff --git a/src/client/.eslintrc.json b/src/client/.eslintrc.json
@@ -3,8 +3,10 @@
   "parserOptions": {
     "project": "./tsconfig.json"
   },
+  "plugins": ["ng-module-sort"],
   "rules": {
     "@angular-eslint/prefer-on-push-component-change-detection": "error",
-    "no-console": "error"
+    "no-console": "error",
+    "ng-module-sort/decorator-array-items": "error"
   }
 }
diff --git a/src/client/package.json b/src/client/package.json
@@ -74,6 +74,7 @@
     "eslint": "^8.57.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-import": "^2.29.1",
+    "eslint-plugin-ng-module-sort": "^1.3.1",
     "eslint-plugin-unused-imports": "^3.0.0",
     "http-server": "^14.1.1",
     "jest": "^29.7.0",

diff --git a/src/client/pnpm-lock.yaml b/src/client/pnpm-lock.yaml
diff --git a/src/client/src/app/components/app/app.component.ts b/src/client/src/app/components/app/app.component.ts
@@ -17,12 +17,12 @@ import { WebPushService } from '../../services/web-push.service';
   selector: 'app-root',
   standalone: true,
   imports: [
-    ConfirmDialogModule,
     CommonModule,
+    ConfirmDialogModule,
     FooterComponent,
-    RouterOutlet,
     MenuComponent,
     NotificationPromptDialogComponent,
+    RouterOutlet,
     ToastModule,
   ],
   providers: [ConfirmationService, MessageService],

diff --git a/src/client/src/app/components/app/menu/menu.component.ts b/src/client/src/app/components/app/menu/menu.component.ts
@@ -22,10 +22,10 @@ import { chainSignals } from '../../../utils/signal.utils';
   imports: [
     ButtonModule,
     CommonModule,
-    MenubarModule,
     MenuModule,
-    TooltipModule,
+    MenubarModule,
     OverlayPanelModule,
+    TooltipModule,
   ],
   templateUrl: './menu.component.html',
   changeDetection: ChangeDetectionStrategy.OnPush,

diff --git a/src/client/src/app/components/events/event-details/event-details.component.ts b/src/client/src/app/components/events/event-details/event-details.component.ts
@@ -42,8 +42,8 @@ import { EventTimeslotDialogComponent } from '../event-timeslot-dialog/event-tim
     ButtonModule,
     CardModule,
     CommonModule,
-    EventTimeslotDialogComponent,
     EventFormComponent,
+    EventTimeslotDialogComponent,
     InterpolatePipe,
     MessagesModule,
     ProgressSpinnerModule,

diff --git a/...client/src/app/components/events/event-timeslot-dialog/event-timeslot-dialog.component.ts b/...client/src/app/components/events/event-timeslot-dialog/event-timeslot-dialog.component.ts
@@ -42,14 +42,14 @@ import { hasTouchScreen } from '../../../utils/user-agent.utils';
   selector: 'app-event-timeslot-dialog',
   standalone: true,
   imports: [
-    DialogModule,
-    CalendarModule,
     ButtonModule,
+    CalendarModule,
+    DialogModule,
     DropdownModule,
+    ErrorTextDirective,
     InputSwitchModule,
     MessagesModule,
     ReactiveFormsModule,
-    ErrorTextDirective,
   ],
   templateUrl: './event-timeslot-dialog.component.html',
   styleUrl: './event-timeslot-dialog.component.scss',

diff --git a/src/client/src/app/components/events/events.component.ts b/src/client/src/app/components/events/events.component.ts
@@ -34,8 +34,8 @@ import { selectSignal } from '../../utils/ngrx.utils';
     MenuModule,
     MessagesModule,
     ProgressSpinnerModule,
-    RouterLink,
     RippleModule,
+    RouterLink,
     TooltipModule,
   ],
   templateUrl: './events.component.html',

diff --git a/src/client/src/app/components/login/login.component.ts b/src/client/src/app/components/login/login.component.ts
@@ -33,12 +33,12 @@ import { TranslateService } from '../../services/translate.service';
     CardModule,
     CommonModule,
     ErrorTextDirective,
-    OnEnterDirective,
-    ReactiveFormsModule,
-    ProgressSpinnerModule,
     InputTextModule,
     InterpolatePipe,
+    OnEnterDirective,
     PasswordModule,
+    ProgressSpinnerModule,
+    ReactiveFormsModule,
     TooltipModule,
   ],
   templateUrl: './login.component.html',

diff --git a/src/client/src/app/components/maps/maps.component.ts b/src/client/src/app/components/maps/maps.component.ts
@@ -36,9 +36,9 @@ function mapMatchesFilter(
     CommonModule,
     FormsModule,
     InputTextModule,
-    MessagesModule,
     MapDialogComponent,
     MapItemComponent,
+    MessagesModule,
     ProgressSpinnerModule,
   ],
   templateUrl: './maps.component.html',

diff --git a/...t/src/app/components/player-events/player-event-details/player-event-details.component.ts b/...t/src/app/components/player-events/player-event-details/player-event-details.component.ts
@@ -49,19 +49,19 @@ const gameDuration = 90 * 60 * 1000;
   selector: 'app-player-event-details',
   standalone: true,
   imports: [
-    CommonModule,
     ButtonModule,
     CardModule,
+    CommonModule,
     DropdownModule,
     FadingMessageComponent,
     FormsModule,
-    ProgressSpinnerModule,
+    InputSwitchModule,
+    MessagesModule,
     OverlayPanelModule,
+    ProgressSpinnerModule,
+    ResetNgModelDirective,
     RouterLink,
     TooltipModule,
-    MessagesModule,
-    InputSwitchModule,
-    ResetNgModelDirective,
   ],
   templateUrl: './player-event-details.component.html',
   styleUrl: './player-event-details.component.scss',

diff --git a/src/client/src/app/components/player-events/player-events.component.ts b/src/client/src/app/components/player-events/player-events.component.ts
@@ -21,7 +21,7 @@ const dayMillis = 24 * 60 * 60 * 1000;
 @Component({
   selector: 'app-player-events',
   standalone: true,
-  imports: [CommonModule, ProgressSpinnerModule, RouterLink, InterpolatePipe, MessagesModule],
+  imports: [CommonModule, InterpolatePipe, MessagesModule, ProgressSpinnerModule, RouterLink],
   templateUrl: './player-events.component.html',
   styleUrl: './player-events.component.scss',
   changeDetection: ChangeDetectionStrategy.OnPush,

diff --git a/src/client/src/app/components/user-settings/user-settings.component.ts b/src/client/src/app/components/user-settings/user-settings.component.ts
@@ -56,8 +56,8 @@ type NotifyTimeslotStartOption = {
     CardModule,
     CommonModule,
     DropdownModule,
-    FormsModule,
     FloatLabelModule,
+    FormsModule,
     InputSwitchModule,
     MessagesModule,
     ProgressSpinnerModule,

diff --git a/src/client/src/app/components/users/user-dialog/user-dialog.component.ts b/src/client/src/app/components/users/user-dialog/user-dialog.component.ts
@@ -56,10 +56,10 @@ import { UserItemComponent } from '../user-item/user-item.component';
     InputTextModule,
     InterpolatePipe,
     ListboxModule,
-    OverlayPanelModule,
     MessagesModule,
-    UserItemComponent,
+    OverlayPanelModule,
     ReactiveFormsModule,
+    UserItemComponent,
   ],
   templateUrl: './user-dialog.component.html',
   changeDetection: ChangeDetectionStrategy.OnPush,

diff --git a/src/client/src/app/components/users/users.component.ts b/src/client/src/app/components/users/users.component.ts
@@ -37,10 +37,10 @@ function userMatchesFilter(map: User | undefined, lowerCaseFilter: string): map
     FormsModule,
     InputTextModule,
     MessagesModule,
+    ProgressSpinnerModule,
     UserDialogComponent,
-    UserPushDialogComponent,
     UserItemComponent,
-    ProgressSpinnerModule,
+    UserPushDialogComponent,
   ],
   templateUrl: './users.component.html',
   styleUrl: './users.component.scss',