Apply suggestions from code review

MaSch0212 · Jul 18, 2024 · 2f8cd98 · 2f8cd98
1 parent 351691f
commit 2f8cd98
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 9 deletions.
diff --git a/...events/event-details/modify-external-uri-dialog/modify-external-uri-dialog.component.html b/...events/event-details/modify-external-uri-dialog/modify-external-uri-dialog.component.html
@@ -15,6 +15,10 @@
       (ngModelChange)="externalUri.set($event)"
     />
     <button pButton icon="i-[mdi--backspace]" (click)="clearExternalUri()"></button>
-    <button pButton icon="i-[mdi--check]" (click)="updateExternalUri()"></button>
   </p-inputGroup>
+
+  <ng-template pTemplate="footer">
+    <p-button [text]="true" [label]="translations.shared_cancel()" (onClick)="visible.set(false)" />
+    <p-button [label]="translations.shared_save()" (onClick)="updateExternalUri()" />
+  </ng-template>
 </p-dialog>
diff --git a/...events/event-details/modify-external-uri-dialog/modify-external-uri-dialog.component.scss b/...events/event-details/modify-external-uri-dialog/modify-external-uri-dialog.component.scss
diff --git a/...s/events/event-details/modify-external-uri-dialog/modify-external-uri-dialog.component.ts b/...s/events/event-details/modify-external-uri-dialog/modify-external-uri-dialog.component.ts
@@ -4,8 +4,8 @@ import {
   inject,
   input,
   signal,
-  ViewChild,
   ElementRef,
+  viewChild,
 } from '@angular/core';
 import { FormsModule } from '@angular/forms';
 import { Store } from '@ngrx/store';
@@ -31,7 +31,6 @@ import { TranslateService } from '../../../../services/translate.service';
     InputTextModule,
   ],
   templateUrl: './modify-external-uri-dialog.component.html',
-  styleUrl: './modify-external-uri-dialog.component.scss',
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class ModifyExternalUriDialogComponent {
@@ -43,7 +42,7 @@ export class ModifyExternalUriDialogComponent {
   protected readonly visible = signal(false);
   protected readonly externalUri = signal('');
 
-  private _inputElement = viewChild.required('inputElement', { read: ElementRef });
+  private readonly _inputElement = viewChild.required('inputElement', { read: ElementRef });
 
   public open(currentValue: string | null | undefined) {
     this.visible.set(true);
@@ -66,6 +65,6 @@ export class ModifyExternalUriDialogComponent {
 
   protected clearExternalUri() {
     this.externalUri.set('');
-    this.inputElement.nativeElement.focus();
+    this._inputElement().nativeElement.focus();
   }
 }
diff --git a/...t/src/app/components/player-events/player-event-details/player-event-details.component.ts b/...t/src/app/components/player-events/player-event-details/player-event-details.component.ts
@@ -210,6 +210,9 @@ export class PlayerEventDetailsComponent {
   }
 
   protected openExternalUri() {
-    window.location.href = this.externalUri() as string;
+    const url = this.externalUri();
+    if (url) {
+      window.location.href = url;
+    }
   }
 }
diff --git a/src/server/host/Endpoints/Administration/Events/UpdateEventEndpoint.cs b/src/server/host/Endpoints/Administration/Events/UpdateEventEndpoint.cs
@@ -27,9 +27,6 @@ public class UpdateEventRequestValidator : Validator<UpdateEventRequest>
     public UpdateEventRequestValidator(IIdService idService)
     {
         RuleFor(x => x.EventId).NotEmpty().ValidSqid(idService.Event);
-        RuleFor(x => x)
-            .Must(x => x.Commit != null || x.ExternalUri != null)
-            .WithMessage("Either Commit or ExternalUri must be set");
     }
 }