Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Favorites module #1692

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Remove unused Favorites module #1692

merged 2 commits into from
Oct 17, 2023

Conversation

alastair
Copy link
Member

@alastair alastair commented Sep 19, 2023

Description
Favorite link in some items isn't used anywhere. Remove it entirely.

This meant that the only item on the SocialModel is tags, so just move tags directly to the items which inherit from SocialModel. Because these are generic foreign keys, there are no migrations

Deployment steps:
The table favorites_favorite still exists, this can be deleted manually or we can create a migration in general to remove it.

While looking at tables, we also have the django_flatpages, django_flatpages_sites, and south_migrationhistory, stopforumspam_cache, stopforumspam_log tables which we could also remove. I suspect the easiest way to remove these is to just delete them

@ffont
Copy link
Member

ffont commented Sep 29, 2023

Thanks for this @alastair! I think it would make sense to remove the unused tables with a migration? Also now there are conflicts that should be fixed. Would you like to do that?

Also mention that the SocialModel was used for a number of models, but tags are really only used for sounds. It is still fine to keep the tags field in the models other than Sound that previously inherited from SocialModel, but maybe we want to add a comment next to the field saying that we don't use them?

@ffont ffont merged commit 9c20745 into master Oct 17, 2023
1 check passed
@ffont ffont deleted the remove-models branch October 17, 2023 09:41
@ffont ffont restored the remove-models branch October 24, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants