Merge pull request #3092 from MTES-MCT/bugfix/3087-3088-sentry-alert

[QA - Sentry] Avertissement et dépréciations
MTES-MCT · Sep 25, 2024 · 779b9ac · 779b9ac
2 parents 672928b + cce2e50
commit 779b9ac
Show file tree

Hide file tree

Showing 43 changed files with 145 additions and 74 deletions.
diff --git a/src/Controller/Back/AffectationController.php b/src/Controller/Back/AffectationController.php
@@ -25,7 +25,7 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Messenger\MessageBusInterface;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Contracts\Cache\TagAwareCacheInterface;
 
 #[Route('/bo/signalements')]

diff --git a/src/Controller/Back/ArchivedSignalementController.php b/src/Controller/Back/ArchivedSignalementController.php
@@ -11,7 +11,7 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 
 #[Route('/bo/signalements-archives')]

diff --git a/src/Controller/Back/AutoAffectationRuleController.php b/src/Controller/Back/AutoAffectationRuleController.php
@@ -13,7 +13,7 @@
 use Symfony\Component\Form\FormInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 
 #[Route('/bo/auto-affectation')]

diff --git a/src/Controller/Back/BackArchivedAccountController.php b/src/Controller/Back/BackArchivedAccountController.php
@@ -16,7 +16,7 @@
 use Symfony\Component\Form\FormInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 
 #[Route('/bo/comptes-archives')]

diff --git a/src/Controller/Back/BackArchivedPartnerController.php b/src/Controller/Back/BackArchivedPartnerController.php
@@ -8,7 +8,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 
 #[Route('/bo/partner-archives')]

diff --git a/src/Controller/Back/BackDashboardController.php b/src/Controller/Back/BackDashboardController.php
@@ -4,7 +4,7 @@
 
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/bo')]
 class BackDashboardController extends AbstractController

diff --git a/src/Controller/Back/BackExpiredAccountController.php b/src/Controller/Back/BackExpiredAccountController.php
@@ -5,7 +5,7 @@
 use App\Repository\UserRepository;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 
 #[Route('/bo/comptes-expires')]

diff --git a/src/Controller/Back/BackInactiveAccountController.php b/src/Controller/Back/BackInactiveAccountController.php
@@ -5,7 +5,7 @@
 use App\Repository\UserRepository;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 
 #[Route('/bo/comptes-inactifs')]

diff --git a/src/Controller/Back/BackSignalementQualificationController.php b/src/Controller/Back/BackSignalementQualificationController.php
@@ -11,7 +11,7 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Serializer\SerializerInterface;
 
 #[Route('/bo/signalements')]

diff --git a/src/Controller/Back/BackStatistiquesController.php b/src/Controller/Back/BackStatistiquesController.php
@@ -15,7 +15,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/bo/statistiques')]
 class BackStatistiquesController extends AbstractController

diff --git a/src/Controller/Back/BackTagController.php b/src/Controller/Back/BackTagController.php
@@ -8,7 +8,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/bo/signalements')]
 class BackTagController extends AbstractController

diff --git a/src/Controller/Back/CartographieController.php b/src/Controller/Back/CartographieController.php
@@ -11,7 +11,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/bo/cartographie')]
 class CartographieController extends AbstractController

diff --git a/src/Controller/Back/CguController.php b/src/Controller/Back/CguController.php
@@ -8,7 +8,7 @@
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/bo/cgu')]
 class CguController extends AbstractController

diff --git a/src/Controller/Back/ExportSignalementController.php b/src/Controller/Back/ExportSignalementController.php
@@ -16,7 +16,7 @@
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\StreamedResponse;
 use Symfony\Component\Messenger\MessageBusInterface;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/bo/export/signalement')]
 class ExportSignalementController extends AbstractController

diff --git a/src/Controller/Back/IdossController.php b/src/Controller/Back/IdossController.php
@@ -11,7 +11,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Messenger\MessageBusInterface;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 
 #[Route('/bo/idoss')]

diff --git a/src/Controller/Back/NotificationController.php b/src/Controller/Back/NotificationController.php
@@ -10,7 +10,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/bo')]
 class NotificationController extends AbstractController

diff --git a/src/Controller/Back/PartnerController.php b/src/Controller/Back/PartnerController.php
@@ -32,7 +32,7 @@
 use Symfony\Component\Form\FormInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 use Symfony\Component\Serializer\Exception\ExceptionInterface;
 use Symfony\Component\Validator\Validator\ValidatorInterface;

diff --git a/src/Controller/Back/ProfilController.php b/src/Controller/Back/ProfilController.php
@@ -22,7 +22,7 @@
 use Symfony\Component\HttpFoundation\File\UploadedFile;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 use Symfony\Component\Validator\Constraints as Assert;
 use Symfony\Component\Validator\Validator\ValidatorInterface;

diff --git a/src/Controller/Back/SignalementActionController.php b/src/Controller/Back/SignalementActionController.php
@@ -20,7 +20,7 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 
 #[Route('/bo/signalements')]

diff --git a/src/Controller/Back/SignalementController.php b/src/Controller/Back/SignalementController.php
@@ -32,7 +32,7 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/bo/signalements')]
 class SignalementController extends AbstractController

diff --git a/src/Controller/Back/SignalementEditController.php b/src/Controller/Back/SignalementEditController.php
@@ -18,7 +18,7 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Serializer\SerializerInterface;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 

diff --git a/src/Controller/Back/SignalementFileController.php b/src/Controller/Back/SignalementFileController.php
@@ -21,7 +21,7 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Messenger\MessageBusInterface;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/bo/signalements')]
 class SignalementFileController extends AbstractController

diff --git a/src/Controller/Back/SignalementListController.php b/src/Controller/Back/SignalementListController.php
@@ -11,7 +11,7 @@
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\Session\SessionInterface;
 use Symfony\Component\HttpKernel\Attribute\MapQueryString;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/bo')]
 class SignalementListController extends AbstractController

diff --git a/src/Controller/Back/SignalementVisitesController.php b/src/Controller/Back/SignalementVisitesController.php
@@ -22,7 +22,7 @@
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 
 #[Route('/bo/signalements')]

diff --git a/src/Controller/Back/TagController.php b/src/Controller/Back/TagController.php
@@ -15,7 +15,7 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;
 
 #[Route('/bo/etiquettes')]

diff --git a/src/Controller/Back/WidgetController.php b/src/Controller/Back/WidgetController.php
@@ -10,7 +10,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Serializer\SerializerInterface;
 
 #[Route('/bo')]

diff --git a/src/Controller/Back/WidgetSettingsController.php b/src/Controller/Back/WidgetSettingsController.php
@@ -10,7 +10,7 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Attribute\MapQueryParameter;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/bo')]
 class WidgetSettingsController extends AbstractController

diff --git a/src/Controller/BailleurController.php b/src/Controller/BailleurController.php
@@ -9,7 +9,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpKernel\Attribute\MapQueryParameter;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 class BailleurController extends AbstractController
 {

diff --git a/src/Controller/FileController.php b/src/Controller/FileController.php
@@ -10,7 +10,7 @@
 use Symfony\Component\HttpFoundation\BinaryFileResponse;
 use Symfony\Component\HttpFoundation\File\File as SymfonyFile;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 class FileController extends AbstractController
 {

diff --git a/src/Controller/HomepageController.php b/src/Controller/HomepageController.php
@@ -18,7 +18,7 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\RateLimiter\RateLimiterFactory;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 class HomepageController extends AbstractController
 {

diff --git a/src/Controller/QuestionController.php b/src/Controller/QuestionController.php
@@ -5,7 +5,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/api')]
 class QuestionController extends AbstractController

diff --git a/src/Controller/Security/SecurityController.php b/src/Controller/Security/SecurityController.php
@@ -12,7 +12,7 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Authentication\AuthenticationUtils;
 
 class SecurityController extends AbstractController

diff --git a/src/Controller/Security/UserAccountController.php b/src/Controller/Security/UserAccountController.php
@@ -16,7 +16,7 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\RateLimiter\RateLimiterFactory;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 
 class UserAccountController extends AbstractController

diff --git a/src/Controller/SignalementController.php b/src/Controller/SignalementController.php
@@ -35,7 +35,7 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 
@@ -143,7 +143,7 @@ public function checkSignalementOrDraftAlreadyExists(
  'already_exists' => true,
  'type' => 'signalement',
  'signalements' => $signalements,
- 'draft_exists' => $existingSignalementDraft ? true : false,
+ 'draft_exists' => (bool) $existingSignalementDraft,
  ]);
  }
 
@@ -233,9 +233,7 @@ public function sendMailContinueFromDraft(
  $signalementDraftRequest,
  );
 
- if (
- $signalementDraft
- ) {
+ if ($signalementDraft) {
  $success = $notificationMailerRegistry->send(
  new NotificationMail(
  type: NotificationMailerType::TYPE_CONTINUE_FROM_DRAFT,
@@ -251,7 +249,7 @@ public function sendMailContinueFromDraft(
  'success' => false,
  'label' => 'Erreur',
  'message' => 'L\'envoi du mail n\'a pas fonctionné, veuillez réessayer ou faire un nouveau signalement.',
- ]);
+ ], Response::HTTP_BAD_REQUEST);
  }
 
  return $this->json(['response' => 'error'], Response::HTTP_BAD_REQUEST);
@@ -420,7 +418,7 @@ public function suiviProcedure(
  EntityManagerInterface $entityManager,
  SuiviFactory $suiviFactory,
  SignalementDesordresProcessor $signalementDesordresProcessor
- ) {
+ ): RedirectResponse|Response {
  $signalement = $signalementRepository->findOneByCodeForPublic($code);
  if (!$signalement) {
  $this->addFlash('error', 'Le lien utilisé est expiré ou invalide.');
@@ -541,7 +539,7 @@ public function suiviSignalement(
  Request $request,
  UserManager $userManager,
  SignalementDesordresProcessor $signalementDesordresProcessor
- ) {
+ ): RedirectResponse|Response {
  if ($signalement = $signalementRepository->findOneByCodeForPublic($code, false)) {
  $requestEmail = $request->get('from');
  $fromEmail = \is_array($requestEmail) ? array_pop($requestEmail) : $requestEmail;

diff --git a/src/Controller/SignalementFileController.php b/src/Controller/SignalementFileController.php
@@ -14,7 +14,7 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/signalement')]
 class SignalementFileController extends AbstractController

diff --git a/src/Controller/StatistiquesController.php b/src/Controller/StatistiquesController.php
@@ -15,7 +15,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Attribute\Route;
 
 class StatistiquesController extends AbstractController
 {