-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Intégration Laine woolmark #831
Merged
Merged
+28
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have this error :
|
paulboosz
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work for me :) Congrats @ccomb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
We got new more robust LCI data for wool.
🍰 Solution
Implement the new wool data: import into brightway, generate an export (still using simapro data)
There is a new
external_db
option is the toplevelcommon.import_.import_simapro_csv
function to link the new activities to an existing db. It's transmitted as is to thelink_technosphere_by_activity_hash
strategy. This is because the new wool data is created using EI 3.10 as a library in SimaPro, so we have to import EI3.10 first then link to it.🏝️ How to test
Get the new
wool.CSV.zip data
, import the wool usingmake import_ecoivent
then rebuild the imagemake image
and do an export withmake export_textile
and check there is no diff.Check the new cool is one third below the previous one in terms of impacts.
ecobalyse-data: laine_woolmark