update repr_llm and add DataFrameSummarizer with customizable summarizing function
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #323 +/- ##
==========================================
- Coverage 84.00% 83.90% -0.10%
==========================================
Files 84 85 +1
Lines 3032 3063 +31
==========================================
+ Hits 2547 2570 +23
- Misses 485 493 +8
Continue to review full report in Codecov by Sentry.
|
shouples
changed the title
repr_llm and add DataFrameSummarizer with customizable summarizing function
rgbkrk
reviewed
Nov 2, 2023
| _instance: "DataFrameSummarizer" = None | ||
| summarizing_func: Optional[Callable] = None | ||
|
|
||
| def __init__(self, summarizing_func: Optional[Callable] = None): |
There was a problem hiding this comment.
If they set it here, shouldn't we not load repr llm's version?
The summarizing_func passed in is likely overridden by the call within _load_repr_llm
There was a problem hiding this comment.
Good point - updating
rgbkrk
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
src/dx/formatters/summarizing.pywithDataFrameSummarizerand some convenience functions to allow easier testing of dataframe summary functions.