removed persistent buffer and fixed some typos.

[iancze]

Closes #143

[iancze]

Something still seems to be wacky with the GitHub actions. The build errored on "docs test #62" but if you look at the error log it's a result from a stale tutorial, which is fixed in this PR. IDK if this has to do with the MystNB cache or the GitHub actions cache or both.

For reference, here is the test status:

[kadri-nizam]

Thanks for fixing the typo in images_test! I suspect it's the cache. Might need to update the conf.py file as it's currently set to cache mode.

MPoL/docs/conf.py

Line 93 in b6d9b24

nb_execution_mode = "cache"

[kadri-nizam]

I think I understand now. The tests were failing on the pull_request_target action because

This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does.

So, actions run using pull_request_target will run tests based on the unchanged codes in the repository. I'll go ahead and merge this since tests run on the head has no errors.

[iancze]

Thanks for tracking this down! If the pull_request_target action is just running on the main branch, is there any utility to it then, at least in our workflow? @jeffjennings

[jeffjennings]

I think pull_request_target is needed to run tests on a PR from a fork (just pull_request wasn’t running tests on the last forked PR), but maybe there’s another workaround.

…

On Sat, Feb 11, 2023 at 17:08 Ian Czekala ***@***.***> wrote: Thanks for tracking this down! If the pull_request_target action is just running on the main branch, is there any utility to it then, at least in our workflow? @jeffjennings <https://github.com/jeffjennings> — Reply to this email directly, view it on GitHub <#150 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEBKMABUPMR5RY6ZQPB3JWLWXAEW7ANCNFSM6AAAAAAUYNO4OE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[iancze]

Thanks, that makes sense!