Fix filename produced by extrap_woa test case #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filename now indicates that it is for January (`_jan`) and includes a datestamp.
xylar
force-pushed
the
fix-woa-extrap-filename
branch
from
1df8c46
to
1068655
Compare
TestingI ran the test on Chrysalis. As expected, it produced a file |
I create a symlink with the `_jan` suffix and this will be used from now on.
|
@vanroekel, do you want to do a quick review of this just by inspection? That should be sufficient, since I tested the file creation and I don't think there's any chance of a mistake in the |
|
Happy for suggestions if the |
|
Thanks @vanroekel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filename now indicates that it is for January (
_jan) and includes a datestamp.Checklist
Testingin this PR) any testing that was used to verify the changesfixes #869