Remove critical passages from landIceFracObserved
#846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to do this before computing `landIceMask`. Otherwise, critical passages cannot be used to open up channels of open ocean through areas covered by (grounded) land ice.
TestingI tested this in conjunction with #807 and MPAS-Dev/geometric_features#203. I am (finally!) able to get the desired behavior close to the Carroll Inlet. On the culled mesh, here is And here is See #844 for details on how it looked without the critical passage. |
|
@darincomeau, could you give this a quick look? Do we finally have something an Stange that we can live with? |
|
@xylar yes, that looks good! |
darincomeau
approved these changes
Jul 18, 2024
|
Thanks @darincomeau! |
This was referenced Jul 18, 2024
|
What got missed here is also setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do this before computing
landIceMask. Otherwise, critical passages cannot be used to open up channels of open ocean through areas covered by (grounded) land ice.Checklist
Testingin this PR) any testing that was used to verify the changes