Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB-LTS Hurricane Test Case #771

Merged
merged 3 commits into from
May 11, 2024
Merged

FB-LTS Hurricane Test Case #771

merged 3 commits into from
May 11, 2024

Conversation

jeremy-lilly
Copy link
Contributor

@jeremy-lilly jeremy-lilly commented Feb 8, 2024

This PR creates a version of the Hurricane Sandy test case from #618 for a new LTS scheme called FB-LTS -- see E3SM-Project/E3SM#6224.

Plots comparing the sea-surface height predicted by FB-LTS versus that predicted by LTS are given below.

FB-LTS:
8557380

LTS:
8557380

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • The E3SM-Project submodule has been updated with relevant E3SM changes
  • The MALI-Dev submodule has been updated with relevant MALI changes
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes
  • New tests have been added to a test suite

@mark-petersen
Copy link
Collaborator

Testing on chicoma and perlmutter using:

./conda/configure_compass_env.py --conda /usr/projects/climate/mpeterse/miconda3 --compiler gnu
source load_dev_compass_1.2.0-alpha.9_chicoma-cpu_gnu_mpich.sh
compass list
...
 298: ocean/hurricane/DEQU120at30cr10rr2/mesh_fblts
 299: ocean/hurricane/DEQU120at30cr10rr2/init_fblts
 300: ocean/hurricane/DEQU120at30cr10rr2/sandy_fblts
 
 compass setup -p ~/repos/E3SM/lts-fb-jer-pr/components/mpas-ocean \
  -w $r/230311_ltsfb_test_DEQU120at30cr10rr2 \
  -n 298 299 300

@mark-petersen
Copy link
Collaborator

Using the E3SM PR E3SM-Project/E3SM#6224 I was able to run this test case on both perlmutter and chicoma and produce the plots above. Thanks @jeremy-lilly for your great work!

@mark-petersen
Copy link
Collaborator

@jeremy-lilly could you check the user's guide here
https://mpas-dev.github.io/compass/latest/users_guide/ocean/test_groups/hurricane.html
which may be edited in this file:
https://github.com/MPAS-Dev/compass/blob/main/docs/users_guide/ocean/test_groups/hurricane.rst
and see if there is a place to add some description of the fblts option? Thanks.

@jeremy-lilly
Copy link
Contributor Author

Thanks @mark-petersen! I've fixed the git history by removing that merge to main, committing a change to the docs, and the rebasing to main. Let me know if that doesn't look right!

Copy link
Collaborator

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The rebase and added notes to the doc page look good. I tested again with intel on chrysalis and gnu on perlmutter to be sure, and everything works!

@xylar
Copy link
Collaborator

xylar commented May 10, 2024

@jeremy-lilly, the E3SM-Project submodule has finally been updated in #821 to bring in the changes you need. Could you rebase (again) to include that? Then, I'll run the tests and (hopefully) approve and merge.

@jeremy-lilly
Copy link
Contributor Author

@xylar, I just rebased! Please let me know if anything doesn't look right. Thanks!

@xylar xylar self-assigned this May 11, 2024
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on Chrysalis (Intel/OpenMPI):

Test Runtimes:
06:22 PASS ocean_hurricane_DEQU120at30cr10rr2_mesh_fblts
46:58 PASS ocean_hurricane_DEQU120at30cr10rr2_init_fblts
06:21 PASS ocean_hurricane_DEQU120at30cr10rr2_sandy_fblts
Total runtime 59:43
PASS: All passed successfully!

and the documentation looks good.

@xylar
Copy link
Collaborator

xylar commented May 11, 2024

@jeremy-lilly, thanks for the hard work and patience!

@xylar xylar merged commit 74edf14 into MPAS-Dev:main May 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants