-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FB-LTS Hurricane Test Case #771
Conversation
Testing on chicoma and perlmutter using:
|
Using the E3SM PR E3SM-Project/E3SM#6224 I was able to run this test case on both perlmutter and chicoma and produce the plots above. Thanks @jeremy-lilly for your great work! |
@jeremy-lilly could you check the user's guide here |
Thanks @mark-petersen! I've fixed the git history by removing that merge to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The rebase and added notes to the doc page look good. I tested again with intel on chrysalis and gnu on perlmutter to be sure, and everything works!
@jeremy-lilly, the E3SM-Project submodule has finally been updated in #821 to bring in the changes you need. Could you rebase (again) to include that? Then, I'll run the tests and (hopefully) approve and merge. |
@xylar, I just rebased! Please let me know if anything doesn't look right. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing on Chrysalis (Intel/OpenMPI):
Test Runtimes:
06:22 PASS ocean_hurricane_DEQU120at30cr10rr2_mesh_fblts
46:58 PASS ocean_hurricane_DEQU120at30cr10rr2_init_fblts
06:21 PASS ocean_hurricane_DEQU120at30cr10rr2_sandy_fblts
Total runtime 59:43
PASS: All passed successfully!
and the documentation looks good.
@jeremy-lilly, thanks for the hard work and patience! |
This PR creates a version of the Hurricane Sandy test case from #618 for a new LTS scheme called FB-LTS -- see E3SM-Project/E3SM#6224.
Plots comparing the sea-surface height predicted by FB-LTS versus that predicted by LTS are given below.
FB-LTS:
LTS:
Checklist
api.rst
) has any new or modified class, method and/or functions listedE3SM-Project
submodule has been updated with relevant E3SM changesMALI-Dev
submodule has been updated with relevant MALI changesTesting
in this PR) any testing that was used to verify the changes