Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run remap_ice_shelf_melt without ice-shelf cavities #661

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Don't run remap_ice_shelf_melt without ice-shelf cavities #661

merged 1 commit into from
Aug 8, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Aug 7, 2023 •
edited
Loading

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added bug Something isn't working ocean labels Aug 7, 2023
@xylar xylar self-assigned this Aug 7, 2023
@xylar
Copy link
Collaborator Author

xylar commented Aug 8, 2023 •
edited
Loading

Testing

I ran files_for_e3sm for both the QU240 and EC30to60 meshes. Whereas the remap_ice_shelf_melt step had been failing for those meshes (because they don't have ice-shelf cavities), it now passes, doing nothing and having no outputs.

I also verified that the QUwISC240 makes the desired link in assembled_files (prescribed_ismf_adusumilli2020.QU240E3r1.20230808.nc) in this step.

@xylar xylar merged commit dfa4979 into MPAS-Dev:main Aug 8, 2023
4 checks passed
@xylar xylar deleted the fix-remap-ice-shelf branch August 8, 2023 07:50
@xylar xylar mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
bug Something isn't working ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar