Increase the max Haney number to 20 #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be more similar to a z-star coordinate, which is not yet supported in MPAS-Ocean init mode.
xylar
force-pushed
the
increase-haney-number
branch
from
cee02eb
to
6226519
Compare
TestingThe following meshes were successfully tested through the
The following mesh required a maximum Haney number of 15:
The following mesh will be tested in a later PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge increases the maximum Haney number (rx1: a measure of how steep and think ocean layer are) to 20 for global ocean initial conditions with ice-shelf cavities (wISC). This should be more similar to a z-star coordinate, which is not yet supported in MPAS-Ocean init mode.
Testing indicated that a Haney number of 20 caused crashes in the ECwISC mesh, so the maximum Haney number for that mesh has been set to 15 instead.
Checklist
Testingin this PR) any testing that was used to verify the changes