Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angleEdge at culled mesh boundaries #580

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Sep 6, 2024

  1. Fix angleEdge at culled mesh boundaries

    Before this fix, `angleEdge` was simply copied from the base mesh
    to the culled mesh.  With this change, `angleEdge` is flipped by
    pi radians if either the first cell on the given edge was removed
    (so the second cell is now the first cell after culling) or if
    only the second cell existed before (and after culling it is now
    the first cell).  This is because `angleEdge` on a boundary edge
    always corresponds to a normal vector pointing from the first
    (and only) cell on the edge to the middle of the edge.
    xylar committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f12cc6a View commit details
    Browse the repository at this point in the history