Correct initialization of soil liquid water content for Noah-MP #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgduda
changed the title
mgduda
requested changes
Nov 1, 2024
There was a problem hiding this comment.
I think it would be very helpful to add some comments to the code to explain what each branch is doing. For example, which cells are affected by this condition
if(ivgtyp(i) == mpas_noahmp%isice_table .and. xice(i) .le. 0._RKIND) thenand which are affected by this condition
if(bexp.gt.0. .and. smcmax.gt.0. .and. psisat.gt.0.) then?
It could also help to give names (and explanatory comments) for the constants used in the code (263.15, 273.149, 0.02).
…ed the initialization of variable sh2o (soil liquid water) prior to calling subroutine NoahmpInitMain in subroutine noahmp_init.
ldfowler58
force-pushed
the
NSF-MPAS/noahmp_fix_tslb
branch
from
e04e590
to
4ba48ba
Compare
|
I corrected the index n to ns in the computation of smois. I added a couple of comments to the initialization, as in the non-refactored version of Noah-MP (also refer to module_sf_noahmpdrv.F in WRF/phys). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the computation of the soil temperature (TSLB) in the Noah-MP land surface scheme. In this PR, we added the initialization of the soil liquid water (SH2O) in subroutine noahmp_init in module mpas_atmphys_lsm_noahmpinit.F prior to calling subroutine NoahmpInitMain.
Prior to adding the initialization of SH2O, running Noah-MP led TSLB to be set to ConstFreezePoint (273.16 K) in SoilSnowWaterPhaseChangeMod.F90 although the input TSLB was greater than ConstFreezePoint on the very first time step. This error occurred because TSLB is calculated as a function of the soil liquid (MassWatLiqTmp) and ice (MassWatIceTmp) water mass, and MassWatLiqTmp is always equal to 0 when not properly initializing SH2O.